TrustedFeeSignerCalculator.sol

The changes applied to the TrustedSignerFeeCalculator adds logic to allow for a PoolId to be specified in the signature that is validated. It is noted that during a premine, as the PoolId will be unknown, we bypass this validation and the provided signature will not include it.

Please also take note of the issues reported in BaseFeeCalculator.sol, as some of these pertain to TrustedSignerFeeCalculator.sol.

[INFO] Incorrect code documentation for _isPremine

The code documentation explains that detect the premine state by referencing transient storage, however this isn't the case when exploring the internal function.

// If we have a transient storage against the PoolId, then we are in a premine. For this reason, we
// can just verify against the origin and deadline, as we would not, at that point, know what the
// PoolId would be.
(bytes32 messageHash, bytes memory signature) = _isPremine(poolId, address(_poolKey.hooks))

[INFO] Duplicate code documentation for PremineSignedMessage

The documentation for the PremineSignedMessage is copied directly from the SignedMessage struct and would benefit from further explanation around it's exact use case.